chore: Update CLI to utilize new error object. #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camden11
approved these changes
Jul 17, 2024
kemmerle
approved these changes
Jul 18, 2024
|
I bumped this back to a draft. I'm going to update this to use all of the changes from the final LDL refactor PR over here |
joe-yeager
commented
Jul 25, 2024
|
|
||
| const i18nKey = 'lib.errorHandlers.index'; | ||
|
|
||
| function logError(error, context = {}) { |
There was a problem hiding this comment.
This is now the singular logError method that will handle the logging. So we can call this and let it determine how to log the output.
joe-yeager
commented
Jul 25, 2024
| } | ||
|
|
||
| if (isHubSpotHttpError(error) || isFileSystemError(error)) { | ||
| logger.error(error.toString()); |
There was a problem hiding this comment.
The HubSpotHttpError class has a toString method that returns a friendly string representation of the contents.
I am add a similar method for the FileSystemError class so this method can be naive about how to format the messages for that class.
…te-new-http-error-object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Depends on HubSpot/hubspot-local-dev-lib#159
Who to Notify
@brandenrodgers @camden11 @kemmerle