Create new prompt for is_available_for_new_content.
#1226
Conversation
tenas97
requested review from
brandenrodgers,
camden11,
kemmerle and
joe-yeager
as code owners
lang/en.lyaml
Outdated
| @@ -1202,6 +1202,7 @@ en: | |||
| selectReactType: "Is this a React module?" | |||
| selectContentType: "What types of content will this module be used in?" | |||
| confirmGlobal: "Is this a global module?" | |||
| availableForNewContent: "Is this available for new content?" | |||
There was a problem hiding this comment.
Would just adjust the wording here to Make this module available for new content?
|
@tenas97 would you mind adding a slightly more detailed description of these changes? It may help someone down the road. Also we get some external 👀 on this repo since it's public so it's always useful to explain what the changes are doing. Side note, is that link to issue 344 pointing to the right place? I'm not seeing how that's related to these changes. |
@brandenrodgers Nice catch with the link. I just updated the description. |
| const AVAILABLE_FOR_NEW_CONTENT = { | ||
| type: 'confirm', | ||
| name: 'availableForNewContent', | ||
| message: i18n(`${i18nKey}.availableForNewContent`), | ||
| default: true, | ||
| }; | ||
|
|
There was a problem hiding this comment.
It looks like the addition of the prompt is causing an AT failure. I think it is as simple as adding another ENTER on this line
Description and Context
Developers use the CLI to create a new module locally. The default file structure we provide includes a default value for
is_available_for_new_contentwithin the meta.json file for the module. This PR just adds a new prompt to the list of prompts for the create module cli command, allowing users to choose how they want to set theis_available_for_new_contentproperty.closes https://git.hubteam.com/HubSpot/hubspot-cli-issues/issues/344