Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading the config relative to a specified directory #362

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

gcorne
Copy link
Contributor

@gcorne gcorne commented Oct 16, 2020

Description and Context

VS Code is built using electron and electron always returns / as the CWD when process.cwd() is run. This will allow us to control where to start looking for the the config file.

See HubSpot/hubspot-cms-vscode#83 and electron/electron#2108

VS Code is built using electron and electron always returns `/` as the
CWD when `process.cwd()` is run. This will allow us to control where to
start looking for the the config file.
@gcorne gcorne requested a review from miketalley October 16, 2020 20:03
@gcorne
Copy link
Contributor Author

gcorne commented Oct 19, 2020

Going to go ahead with this.

@gcorne gcorne merged commit 439fc3e into master Oct 19, 2020
@gcorne gcorne deleted the vscode-usage-tracking branch October 19, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant