Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #381 - downloadHubDbTable would download incorrect results for large tables #384

Merged
merged 5 commits into from
Nov 10, 2020

Conversation

drewjenkins
Copy link
Contributor

Description and Context

HubDB rows api changed from v2 to v3, updated the way we call it to reflect this

Resolves #381

@darkmavis1980

@anthmatic
Copy link
Contributor

@drewjenkins
Copy link
Contributor Author

drewjenkins commented Nov 9, 2020

I think this also affects

https://github.com/HubSpot/hubspot-cms-tools/blob/26088f3b254c014618ca28f821eb8230fc325de7/packages/cms-lib/hubdb.js#L171

Good call, I'll get that patched up too Done

packages/cms-lib/hubdb.js Outdated Show resolved Hide resolved
Copy link
Contributor

@anthmatic anthmatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One note about function name, otherwise looks slick 🚀

@drewjenkins drewjenkins merged commit b8764f3 into master Nov 10, 2020
@drewjenkins drewjenkins deleted the issue/381 branch November 10, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hubdb function downloadHubDbTable incorrectly download table rows
3 participants