Updated endpoint used for build/deploy which supports polling and added polling #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewjenkins
reviewed
Jan 12, 2021
| @@ -30,6 +30,23 @@ const makeSpinner = (actionText, functionPath, accountIdentifier) => { | |||
| ); | |||
| }; | |||
|
|
|||
| const pollBuildStatus = (accountId, buildId) => { | |||
There was a problem hiding this comment.
Nice. Is 1000 too fast?
There was a problem hiding this comment.
I set it to a faster poll because the build seems to happen pretty quickly in some cases. Although, this is a good point because the BE only has PROCESSING, ERROR, and SUCCESS states ATM, so we can dial this back. I'll go with 5000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Changed custom serverless build endpoint from
cms/v3/functions/packagetocms/v3/functions/buildwhich returns abuildId. This is used to pollcms/v3/functions/build/((id))/pollfor build status.This update does not change anything visibly or from a flow standpoint, it is done to allow polling to be done instead of having the BE endpoint only respond when the build has completed.
The
--deleteoption has also been removed from thehs functions deploycommand as the backend handles properly deleting associated built packages when serverless function folders are deleted.Who to Notify
@bkrainer @gcorne @williamspiro