copy .env.template to .env if it exists #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksvirkou-hubspot
requested review from
atanasiuk-hubspot,
asalauyeu-hubspot and
tpeuneu-hubspot
ksvirkou-hubspot
changed the title
anthmatic
approved these changes
Mar 26, 2021
gcorne
reviewed
Mar 26, 2021
| @@ -260,6 +260,9 @@ exports.handler = async options => { | |||
| } | |||
| ); | |||
| if (created) { | |||
| if (fs.existsSync(`${filePath}/.env.template`)) { | |||
| fs.copySync(`${filePath}/.env.template`, `${filePath}/.env`); | |||
| } | |||
There was a problem hiding this comment.
One thing that I am not sure I understand is why the boilerplates should not be adjusted to have .env.
There was a problem hiding this comment.
Hi, @gcorne, adjusting .env to the boilerplates is a good idea, but we have some concerns about excluding it from .gitignore since:
- it needs to be gitignored during our development
- user will most likely add it to .gitignore again
So, wondering, how do you see adjusting .env to the boilerplates?
There was a problem hiding this comment.
Alright, I see why using a template was chosen. I think copying from a template is okay, although I wonder if moving the file would be better.
gcorne
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copy .env.template to .env if it exists after downloading a sample app