Alert user of Theme Preview path after they've updated a file within a theme #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthmatic
reviewed
Apr 29, 2021
|
Should we provide this behavior on upload too? |
gcorne
reviewed
Apr 29, 2021
| return queue.add(() => { | ||
| return upload(accountId, file, dest, apiOptions) | ||
| .then(() => { | ||
| logger.log(`Uploaded file ${file} to ${dest}`); | ||
| notifyOfThemePreview(file, accountId); |
There was a problem hiding this comment.
@drewjenkins Is there a reason we're doing this in the watch library instead of the watch command? I ask because the original conception of the library package was that it could be used in other scenarios beyond just @hubspot/cli.
I also wonder if outputting as part of initial command output perhaps after the the uploading of the folder if --initial-upload is passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #244
Description and Context
We want to give users a link to the theme preview when they update it
Screenshots