Granular template checks for marketplace theme validation #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandenrodgers
changed the title
drewjenkins
reviewed
Jun 1, 2021
|
|
||
| const TEMPLATE_LIMIT = 50; | ||
| const TEMPLATE_COUNT_IGNORE_LIST = ['global_partial', 'none']; | ||
| const VALIDATIONS_BY_TYPE = { |
anthmatic
reviewed
Jun 1, 2021
packages/cli/lib/validators/marketplaceValidators/theme/TemplateValidator.js
Outdated
Show resolved
Hide resolved
brandenrodgers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Using this PR as the base just to split up the work into separate PR's to make it more reviewable.
This adds more accurate template checking to the theme validation command. Now we're correctly checking for label and screenshot annotations depending on the template type.
Screenshots
TODO
Who to Notify
cc/ @KatzMitch