Project support #537
Project support #537
Conversation
| describe: 'Path to a project folder', | ||
| type: 'string', | ||
| }); | ||
| // TODO: |
There was a problem hiding this comment.
I was previously accounting for these to be passed as options. Not exactly sure how that should work with the new config file. Thinking of keeping these and getting some UX feedback.
| exports.describe = false; //'Commands for working with projects'; | ||
|
|
||
| exports.builder = yargs => { | ||
| addOverwriteOptions(yargs, true); | ||
| addConfigOptions(yargs, true); | ||
| addAccountOptions(yargs, true); | ||
|
|
||
| // TODO: deploy must be updated | ||
| yargs.command(deploy).demandCommand(1, ''); |
There was a problem hiding this comment.
Not currently used in the flow. Will need to be adjusted eventually, but will mostly stay the same so keeping this for now.
packages/cli-lib/api/dfs.js
Outdated
| uri: DEVELOPER_FILE_SYSTEM_API_PATH, | ||
| }); | ||
| } | ||
| // TODO: paging? |
There was a problem hiding this comment.
Did we want to add paging, or is this a reminder for later?
There was a problem hiding this comment.
We'll need to add paging but I'll remove the TODO for now
| const { path: projectPath } = options; | ||
| const accountId = getAccountId(options); | ||
|
|
||
| // TODO: |
There was a problem hiding this comment.
Should we enable this now?
| logger.log(''); | ||
| logger.log('> Welcome to HubSpot Developer Projects!'); | ||
| logger.log('-------------------------------------------------------------'); | ||
| logger.log('Getting Started'); | ||
| logger.log('1. hs project upload'); | ||
| logger.log( | ||
| ' Upload your project files to HubSpot. Upload action adds your files to a build.' | ||
| ); | ||
| logger.log(); | ||
| logger.log('2. View your changes on the preview build url'); | ||
| logger.log(); | ||
| logger.log('Use `hs project --help` to learn more about the command.'); | ||
| logger.log('-------------------------------------------------------------'); | ||
| }; |
|
Pending answers to Mike's questions this all lgtm! This is a solid first pass 👌 |
These were mostly reminders for me to come back to later or enable things like tracking when we really need it but in the interest of keeping things cleaner I enabled tracking and removed most of the TODOs for now. |
Description and Context
Updated project support:
projectsrenamed toprojectChanges to
hsproject.json:{ "name": "weather_app", "srcDir": "src" }NOTE: I've purposely left some TODOs that I'll address later, I'd just like to get the basics in so that we can get a solid feedback loop in.
Screenshots
TODO
Who to Notify