Add build status to project upload #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketalley
reviewed
Aug 23, 2021
| @@ -4,10 +4,15 @@ const path = require('path'); | |||
| const chalk = require('chalk'); | |||
| const findup = require('findup-sync'); | |||
| const { prompt } = require('inquirer'); | |||
| const Spinnies = require('spinnies'); | |||
There was a problem hiding this comment.
We were using ora for loading spinners elsewhere in the CLI. Is there a reason to have both or should we use ora here also?
It looks like having multiple spinners displayed simultaneously for the purpose of displaying the status of the subbuilds is not possible using ora. I think we should work on updating uses of ora to use spinnies in the future.
There was a problem hiding this comment.
Yeah, that's exactly it and I agree
anthmatic
commented
Aug 23, 2021
| build.status === BUILD_STATUS.SUCCESS || | ||
| build.status === BUILD_STATUS.FAILURE | ||
| ); | ||
| }; |
miketalley
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
After successful project upload, polls for build status
Screenshots
Spinners while project dependencies are building
Success message
General failure
Failure of a single dependency build
