Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project command improvements #548

Merged
merged 5 commits into from
Sep 13, 2021
Merged

Project command improvements #548

merged 5 commits into from
Sep 13, 2021

Conversation

anthmatic
Copy link
Contributor

@anthmatic anthmatic commented Sep 7, 2021

Description and Context

-Validates presence of name and srcDir within hsproject.json
-Validates thatsrcDir exists
-Adjusts command output to match designs more closely
-Adds a "spinner" to the upload step

Init:
image

Upload:
image

Screenshots

TODO

Who to Notify

@anthmatic anthmatic marked this pull request as ready for review September 9, 2021 19:09
Copy link
Contributor

@brandenrodgers brandenrodgers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally and lgtm!

@anthmatic anthmatic merged commit 1977bc2 into master Sep 13, 2021
@anthmatic anthmatic deleted the fix/projects-bugs branch September 13, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants