Prevent spinnies error on upload if buildPolling fails #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| deployedBuildId | ||
| ); | ||
| } catch (err) { | ||
| logger.error(err); |
There was a problem hiding this comment.
Could you elaborate on why moving this here fixes the problem?
Also, what type of errors can exist here? Are they api-related errors, or internal JS errors? If it's the latter I think we should switch this to be logger.debug() so we don't fill the console with internal js errors.
There was a problem hiding this comment.
Good call on error types, I'll address that.
Also, after looking at this again don't think think that this change is relevant here. It is in upload.js, so I'll add a comment there
anthmatic
commented
Sep 24, 2021
| ); | ||
| await pollBuildStatus(accountId, projectName, upload.buildId); |
There was a problem hiding this comment.
If this fails, the spinnies.fail() within the catch statement may throw an error because the spinner was already removed above
anthmatic
changed the title
brandenrodgers
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
When polling was sharing a catch block with the upload function, which was causing issues where an inactive "spinner" was incorrectly updated.
Screenshots
TODO
Who to Notify