-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding File Management #138
Conversation
…ton depending on command availability
src/lib/commands.ts
Outdated
} | ||
}); | ||
terminal.sendText("echo 'Installing the HubSpot CLI.'"); | ||
terminal.sendText('npm i -g @hubspot/cli@latest'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we allow them to specify npm / yarn / other ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interestingly, Stripe (which is where the thought for this functionality originated from) sends the user to the documentation to install from various providers -- perhaps we could do a combination here where the main Install button that you have is npm (we can call this out with text around the button) and we can add a link below to send to documentation about installing the CLI for other providers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I did see that Stripe was sending folks to the docs instead of doing the installation. I was going by the description of the issue -> https://git.hubteam.com/HubSpot/cms-developer-tooling/issues/54 and discussion with @hs-cboamah to create the button.
There is a link above the button that leads to https://developers.hubspot.com/docs/cms/developer-reference/local-development-cli. Here is the text with the button under it...
Should we change the text, or do we want to change the flow of this to be a link to the docs for installation? I think it works well with the link to the docs and button for easy install. 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think keeping the button is totally fine -- let's just adjust the text around the installation button.
"In order to use additional features that are not currently available within the HubSpot VS Code extension, you can install the HubSpot CLI (via npm) using the button below. To see other available installation options, check out the documentation."
We'll have to follow up with additions/changes/updates to the docs in order to support this. Probably a CMS Developer Doc page dedicated to the extension would help. Otherwise, in the interim, we can create some quick documentation that lives in the readme of the repo for CLI (or extension) in order to send devs to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
What kind of info do you see this doc containing?
For the quick links (based on the demo you gave earlier today): IMO, the links you have in the Quick Links section should point to the -- For the CLI section -- currently the title there is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else LGTM! 🔥
I was setting up the As for the |
Description
Adds
Quick Links
andTools
sections. Allows installation and updating of@hubspot/cli
through buttons.Features
viewsWelcome
which npm
)which hs
)Install CLI
button that will runnpm i -g @hubspot/cli@latest
in terminal and show information popup when completeUpdate CLI
button that will runnpm i -g @hubspot/cli@latest
in terminal and show information popup when completetreedata
section with links to commandsDemo
https://www.loom.com/share/e252eeb818ff404b817480e81c934863
/cc @hs-cboamah @TanyaScales @anthmatic @jsines