Extension can be activated and opened when no workspace folder is open #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extension
activitybaritem was disabled when no workspace folder is open (!workbench.explorer.emptyView.active). This PR allows the extension to be activated and opened and adds a notification section to notify the user that they need to open a folder.The content of the section mimics the one displayed in the
exploreractivity bar item provided with VSCode. The "Open Folder" button opens the file picker and reloads the extension when a folder is selected/opened. The "Clone Repository" button runs the "Git: Clone"(git.clone) command, which will allow a repository to be opened instead.Note: The ability to mirror the
workbench.explorer.emptyViewby embedding it into our menu does not work. I filed a bug for this in vscode -> microsoft/vscode#171859Once this bug is fixed, we can remove our
hubspot.viewsWelcome.noFolderOpenedwelcome view in favor of embeddingworkbench.explorer.emptyView.