Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: Remove default exports and add linting rule for default exports. #165

Merged
merged 2 commits into from
Jul 25, 2024
Merged

fix!: Remove default exports and add linting rule for default exports. #165

merged 2 commits into from
Jul 25, 2024

Conversation

joe-yeager
Copy link
Contributor

@joe-yeager joe-yeager commented Jul 24, 2024 •
edited
Loading

Description and Context

Note: This will be a breaking change, so this PR is targeting the next branch and will be in the next major

  • Remove default exports and add a linting rule to prevent usage.

Who to Notify

@camden11 @brandenrodgers @kemmerle

@joe-yeager joe-yeager marked this pull request as ready for review July 24, 2024 20:57
@joe-yeager joe-yeager changed the base branch from main to next July 24, 2024 21:01
@joe-yeager joe-yeager changed the title chore: Remove default exports and add linting rule for default exports. chore!: Remove default exports and add linting rule for default exports. Jul 24, 2024
@joe-yeager joe-yeager changed the title chore!: Remove default exports and add linting rule for default exports. fix!: Remove default exports and add linting rule for default exports. Jul 24, 2024
camden11
camden11 approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@camden11 camden11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM. Will just have to remember each of these changed exports so we can be sure to replace them properly in the CLI

@joe-yeager
Copy link
Contributor Author

Nice! LGTM. Will just have to remember each of these changed exports so we can be sure to replace them properly in the CLI

Good callout. I should have linked the PRs, but I have a PR to update the CLI. I was only able to find one usage

kemmerle
kemmerle approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@kemmerle kemmerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed these changes, as well, and tried out commands locally with these changes. Everything's working for me.

@joe-yeager joe-yeager merged commit 72cd558 into next Jul 25, 2024
@joe-yeager joe-yeager deleted the jy/remove-default-exports branch August 28, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camden11 camden11 camden11 approved these changes

@kemmerle kemmerle kemmerle approved these changes

@brandenrodgers brandenrodgers Awaiting requested review from brandenrodgers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joe-yeager @camden11 @kemmerle