Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unauthed http option #171

Merged
merged 7 commits into from
Aug 6, 2024
Merged

Unauthed http option #171

merged 7 commits into from
Aug 6, 2024

Conversation

camden11
Copy link
Contributor

@camden11 camden11 commented Aug 2, 2024

Description and Context

This adds new methods for hitting hubspot endpoints that don't require auth. See thread for more details on this ask:
https://hubspot.slack.com/archives/C076QV345ME/p1721328218238189

Decided it would be easier to put this into the next branch due to the changes to http, even though it doesn't actually have any breaking changes.

TODO

I feel like there might be a better way to name these functions? I couldn't think of anything that I really liked though.

Who to Notify

@brandenrodgers @kemmerle @joe-yeager

@camden11 camden11 marked this pull request as ready for review August 5, 2024 17:31
http/index.ts Outdated Show resolved Hide resolved
@camden11
Copy link
Contributor Author

camden11 commented Aug 5, 2024

Something @brandenrodgers and I just talked about in our 1:1 is moving the unauthed methods to their own file but having them use the standard names.

so something like import { get } from '@hubspot/local-dev-lib/http/unauthed'

@kemmerle
Copy link
Contributor

kemmerle commented Aug 5, 2024

@camden11, I agree with Branden that moving these methods into their own file and using standard names is more streamlined.

@camden11 camden11 requested a review from joe-yeager August 6, 2024 16:48
Copy link
Contributor

@brandenrodgers brandenrodgers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 nice I like this unauthed pattern

@camden11 camden11 merged commit 90a85d4 into next Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants