fix: Logging fixes #185
Merged
fix: Logging fixes #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al-dev-lib into jy/fix-next-errors
joe-yeager
changed the title
requiredScopes to validation errors
joe-yeager
commented
Aug 20, 2024
| @@ -116,7 +121,7 @@ export class HubSpotHttpError<T = any> extends Error { | |||
| generatedContext.request = cause.config?.url; | |||
|
|
|||
| // Allow the provided context to override the generated context | |||
| this.context = { ...generatedContext, ...this.context }; | |||
| this.derivedContext = { ...this.derivedContext, ...generatedContext }; | |||
There was a problem hiding this comment.
Splitting this into derivedContext to prevent collisions with the user provided context and it doesn't unintentionally slip unwanted details into the message.
camden11
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
Fixes the error where we weren't logging out the required scopes.
Fixes errors with the payloads getting logged
Screenshots
Before
After
TODO
Who to Notify
@kemmerle @brandenrodgers @camden11