fix: Use path.sep to fix path check on Windows #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camden11
reviewed
Sep 5, 2024
There was a problem hiding this comment.
I think the same thing with prettier happened to Allison. Could you try deleting node modules and re-installing and see if that keeps these files the same? Just want to make sure we don't end up in another situation where they go back and forth every PR.
path.sep stuff looks good though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
This fixes an issue on Windows where the path wasn't being checked correctly. The path.sep value will be
/on MacOS and\\on Windows.I'm not sure what's going on with Prettier, but it formatted a few other files for some reason
Screenshots
TODO
Who to Notify