Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return the tracking request when not authenticated #191

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

brandenrodgers
Copy link
Contributor

Description and Context

This is for consistency between the authed and unauthed tracking events. I wasn't able to test this, but I'm fairly certain this is preventing our unauthed requests from sending correctly in some cases. The impact is that our tracking for successful runs of hs init isn't accurate

Screenshots

TODO

Who to Notify

Copy link
Contributor

@kemmerle kemmerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@brandenrodgers brandenrodgers merged commit e495bd1 into main Sep 6, 2024
1 check passed
@brandenrodgers brandenrodgers deleted the br/return-unauthed-tracking-request branch September 6, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants