chore!: Rename Mode to CmsPublishMode #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camden11
changed the title
camden11
requested review from
brandenrodgers,
kemmerle and
joe-yeager
as code owners
camden11
changed the title
kemmerle
reviewed
Nov 25, 2024
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@hubspot/local-dev-lib", | |||
| "version": "2.3.0", | |||
| "version": "0.1.0-experimental.0", | |||
There was a problem hiding this comment.
Remember to change this back when you merge.
kemmerle
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Context
See https://git.hubteam.com/HubSpot/hubspot-cli-issues/issues/718
This updates all references to
modetocmsPublishModeand renames all related functions and variables. It also changes thedefaultModesetting withinhubspot.config.ymltodefaultCmsPublishMode. Both the new and legacy config modules have been updated to be able to read configs with eitherdefaultModeordefaultCmsPublishMode, but will now always usedefaultCmsPublishModewhen making updates to config files.Currently released on
v0.1.0-experimental.0TODO
Test thoroughly. Also might be worth updating the config unit tests to test the backwards compatibility functionality/
Who to Notify
@brandenrodgers @kemmerle @joe-yeager