Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify allowedUrls in the public app getting started template #38

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

paulrishav
Copy link

Modify allowedUrls in the public app getting started template to clearly indicate to the developer that they can invoke developer owned backends and not Hubspot public APIs through hubspot.fetch()

…rly indicate to the developer that they can invoke developer owned backends and not Hubspot public APIs through hubspot.fetch()
@paulrishav
Copy link
Author

@mendel-at-hubspot

@@ -2,7 +2,7 @@
"name": "Get started with public apps",
"uid": "get-started-public-app",
"description": "An example to demonstrate how to build a public app with developer projects.",
"allowedUrls": ["https://api.hubapi.com"],
"allowedUrls": ["https://api.yourplatform.com"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think https://api.example.com would be a bit more conventional, but we don't have to overthink it.

@kporter999 kporter999 merged commit 882eba5 into HubSpot:main Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants