Limit output size #108
Merged
Limit output size #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er than just individual node sizes.
| private long maxOutputSize; | ||
|
|
||
| public OutputList(long maxOutputSize) { | ||
|
|
There was a problem hiding this comment.
Nit: why the extra line here?
|
|
||
| public void addNode(OutputNode node) { | ||
|
|
||
| if (maxOutputSize > 0 && node.getSize() > maxOutputSize) { |
There was a problem hiding this comment.
Does this only check the size of this node against the max? What if we're adding a large number of very small nodes? Just pushed a test that shows what I mean.
If this is only intended to limit the size of individual nodes, I think we should change the name of maxOutputSize to something else.
There was a problem hiding this comment.
should be fixed now
Previously I was only checking size as we rendered individual output nodes. This helped prevent any one node from getting too big and short circuiting the render, but it was possible to have output that was too big when adding up the output nodes and rendered blocks.
|
🍹 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a configuration option to limit the maximum size of an output node.
@jmagnarelli-hs