update ** and // to support int/float literals #234
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes address issue #169.
The current logic for // and ** specifies that the operands need to be
IDENTIFIER
symbols. This works when jinjava variables are used, but fails for actual numerical values (as these areINTEGER
symbols, notIDENTIFIER
).The fix for this was to remove the special // and ** logic in
ExtendedParser.value
and instead rely on the existing extension framework via the pre-existing calls toParser.getExtensionHandler