Add support for manual attribution update #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertlong
reviewed
Jan 13, 2021
| <ul> | ||
| {contentAttributions.map( | ||
| (a, i) => | ||
| a.author && |
There was a problem hiding this comment.
We check for author down below as well. I think maybe we just want to check for title here?
There was a problem hiding this comment.
As long as we want to show attribution if just one is present. Not sure if it makes sense to show only the title without knowing the author or just the author without knowing to which asset it is referring to. In my head valid attribution required both.
|
@robertlong Thanks for the review. I've fixed most of it. Still have doubts about the author/title check. |
keianhzo
force-pushed
the
feature/manual-attribution
branch
from
782da8b to
a60d3da
Compare
|
Looks good, excited to get it out there! |
This was referenced Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #414 This PR adds support to show/edit attribution information in scene assets, specifically Model, Video, Image and Spawners. What this does right now:
resolveMediaand then updated with the asset file info in case it's available (i.e. GLTF embedded asset info)It also fixes an issue with adding new source to audio/video nodes that threw an exception in Chrome an the updated element didn't work:
We still need to solve the case where we can add per node GLTF attribution information based on https://github.com/KhronosGroup/glTF/blob/master/extensions/2.0/Khronos/KHR_xmp/README.md Right now none of the sources support it but would be useful for exporting GLTF Spoke scenes while keeping all the attribution data. See #1044