Custom Navigation Meshes #1077
Custom Navigation Meshes #1077
Conversation
src/editor/nodes/FloorPlanNode.js
Outdated
| })() | ||
| ); | ||
| } else { | ||
| node._navMeshSrc = navMeshSrc; |
There was a problem hiding this comment.
You might consider just assigning this above right after navMeshMode like:
node._navMeshSrc = navMeshSrc || ""
to get rid of the need for the nested if, and make the default value more explicit.
src/editor/nodes/FloorPlanNode.js
Outdated
| if (navMeshMode === NavMeshMode.Custom) { | ||
| loadAsync( | ||
| (async () => { | ||
| await node.load(navMeshSrc, onError); |
There was a problem hiding this comment.
Do we need the wrapping function? I think loadAsync(node.load(navMeshSrc, onError))should do the same thing assuming loadAsync just expects a promise.
| this.setNavMesh(new Mesh(geometry, new MeshBasicMaterial({ color: 0x0000ff, transparent: true, opacity: 0.2 }))); | ||
|
|
||
| if (this.navMesh) { | ||
| this.navMesh.visible = this.editor.selected.indexOf(this) !== -1; |
There was a problem hiding this comment.
Is this needed? Guessing since you are emitting selectionChanged at the end of this function the state should already get updated.
There was a problem hiding this comment.
Yeah, it looks like onSelect() isn't called in response to the selectionChanged event 🤷♂️
| </> | ||
| ) : ( | ||
| <InputGroup name="Custom Navmesh Url"> | ||
| <ModelInput value={node.navMeshSrc} onChange={this.onChangeNavMeshSrc} /> |
There was a problem hiding this comment.
Not new to this PR, just anything taking a model in general so not something we need to address in this PR, but we might want to think about how we could visually indicate somehow that this field can have models dragged into it from assets. Ideally there might even be a little button on the field that pops up an asset picker (similar to how it works in Unity)
robertlong
added
whats new
You can now specify a model for a custom navigation mesh. In the Floor Plan element's properties panel change the floor plan mode to "Custom" and drag and drop a model into the "Custom Navmesh Url" field.
Fixes #1075