Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled/Disabled Elements and Default Collapsed State #1079

Merged
merged 4 commits into from
Jan 21, 2021

Conversation

robertlong
Copy link
Contributor

@robertlong robertlong commented Jan 20, 2021

image

Spoke elements can now be disabled, preventing them from being exported or included in nav mesh calculations. This can be helpful when testing scene elements or including additional content in your project for people remixing your scene.

Additionally, elements are now defaulted to the collapsed state. This should help declutter your scene and make groups more useful.

These two features can be used together to make make more advanced remixiable projects.

@robertlong robertlong added the whats new Include this PR on the "What's New" page label Jan 20, 2021
@keianhzo keianhzo self-assigned this Jan 20, 2021
@keianhzo keianhzo self-requested a review January 20, 2021 23:56
Copy link
Contributor

@keianhzo keianhzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only thing I've seen is that even if the node is disabled we are still adding attribution information to the published scene. I guess we should only add that for the the enabled nodes.

@robertlong robertlong dismissed keianhzo’s stale review January 21, 2021 19:22

Fixed the issue with attributions and found another with animations that I also fixed.

@robertlong robertlong merged commit de2209b into master Jan 21, 2021
@robertlong robertlong deleted the feature/enabled-flag branch January 21, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
whats new Include this PR on the "What's New" page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants