Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitECS: Fail to switch scene #6206

Closed
takahirox opened this issue Aug 11, 2023 · 2 comments
Closed

bitECS: Fail to switch scene #6206

takahirox opened this issue Aug 11, 2023 · 2 comments
Labels
bug needs triage For bugs that have not yet been assigned a fix priority new-loader
Milestone
New Loader Release

Comments

@takahirox
Copy link
Contributor

takahirox commented Aug 11, 2023 •
edited
Loading

Description

With new loader enabled switching scene fails. I keep seeing dark.

To Reproduce
Steps to reproduce the behavior:

  1. Enter a room with new loader enabled
  2. Change the scene
  3. Screen is blacked out
  4. New scene won't show. You keep seeing dark

Expected behavior

Scene switch works even with new loader enabled

Screenshots

Console error

Screenshot_2023-08-11_at_1 41 00_PM

Hardware

  • Device: Desktop
  • OS: Windows
  • Browser: Chrome

Additional context

  • Audio (Voice) kept working
@takahirox takahirox added bug needs triage For bugs that have not yet been assigned a fix priority new-loader P1 Address as quickly as possible labels Aug 11, 2023
@takahirox takahirox added this to the New Loader Release milestone Aug 11, 2023
@takahirox
Copy link
Contributor Author

takahirox commented Aug 14, 2023 •
edited
Loading

I found the problem seems to be scene specific. I can reproduce the problem by switching from the Outdoor Festival scene but couldn't reproduce by switching from other scenes so far. I guess a certain component included in the Outdoor Festival scene causes the problem?

I will remove P1 label for now because it doesn't seem to be a generic scene switching problem. (But still near P1 in my mind because even if the problem seems to be scene specific switching a scene is still one of the basic features.)

@takahirox takahirox removed the P1 Address as quickly as possible label Aug 14, 2023
@takahirox takahirox mentioned this issue Aug 15, 2023
Merged
@takahirox
Copy link
Contributor Author

Fixed by #6217

takahirox added a commit that referenced this issue Aug 17, 2023
@takahirox
bitECS: Prevent Three.js Audio.disconnect error
170cf09 
**Problem**

Disconnecting Three.js Audio can cause an error

#6206

Three.js Audio.disconnect() seems to expect Audio.source is
non-null. Audio.source is set via .set*Source() or .play().

https://github.com/MozillaReality/three.js/blob/hubs-patches-141/src/audio/Audio.js

Hubs Client seems to call Audio.disconnect() before setting
source in some scenarios.

**Solution**

Add a guard to check Audio.source is non-null before calling
Audio.disconnect()

**Additional context**

There might be a chance that the fact Audio.source keeps being
unset in some scenarios might be a bug. We might also need to
investigate it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug needs triage For bugs that have not yet been assigned a fix priority new-loader
Projects
None yet
Milestone
New Loader Release
Development

No branches or pull requests
1 participant
@takahirox