Support for Mic selection #3620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@keianhzo could you resolve these merge conflicts? I would just get rid of the changes to the localization files. We don't use |
keianhzo
force-pushed
the
room-ui-redesign-audio
branch
2 times, most recently
from
a44e3d3 to
ba0a83b
Compare
|
@robertlong The conflicts should be fixed. |
robertlong
reviewed
Jan 7, 2021
keianhzo
force-pushed
the
room-ui-redesign-audio
branch
from
ba0a83b to
dbf1463
Compare
|
@robertlong This should be ready to merge. I've removed the translations. I run out of time for the refactor, I'll do it as a follow-up when this lands. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2799 This PR adds support for Mic selection from preferences.