Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/escape key in modal #3650

Merged
merged 5 commits into from
Jan 7, 2021
Merged

Bug/escape key in modal #3650

merged 5 commits into from
Jan 7, 2021

Conversation

johnshaughnessy
Copy link
Contributor

Fix #3492

robertlong
robertlong approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@robertlong robertlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit, otherwise lgtm!

src/react-components/profile-entry-panel.js Outdated Show resolved Hide resolved
@robertlong robertlong merged commit ae3a235 into room-ui-redesign Jan 7, 2021
@robertlong robertlong deleted the bug/escape-key-in-modal branch January 7, 2021 18:02
@johnshaughnessy johnshaughnessy mentioned this pull request Mar 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertlong robertlong robertlong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnshaughnessy @robertlong