Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable ability to hide lobby modal with spectate button #3776

Merged
merged 2 commits into from
Jan 27, 2021
Merged

Re-enable ability to hide lobby modal with spectate button #3776

merged 2 commits into from
Jan 27, 2021
+2 −6

Conversation

robertlong
Copy link
Contributor

This PR re-enables the ability to hide lobby modal with spectate button and makes it so you can toggle the UI visibility from anywhere in the app. Because enable_lobby_ghosts is checked when adding the is-ghost class, we can be sure that flying is disabled when enable_lobby_ghosts is not set.

@robertlong robertlong merged commit 6d26cef into master Jan 27, 2021
@robertlong robertlong deleted the feature/hide-lobby-modal branch January 27, 2021 20:41
@misslivirose misslivirose mentioned this pull request Jan 27, 2021
Closed
This was referenced Mar 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnshaughnessy johnshaughnessy johnshaughnessy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertlong @johnshaughnessy