document.body can be null when setLocale is first called #4178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common, but non-deterministic, console error is being thrown in
setLocale
because document.body can be null.It should be safe to skip raising the event with
?.
in this situation because at best it was throwing an exception before.A common pattern elsewhere in the codebase is to hang these events off
window
(which is guaranteed to be non-null) rather thandocument.body
, and that would appear to be preferable in this case as well, but there may be something special about events on thedocument.body
that I'm missing.