Bump A-Frame to recent master #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't find any issues in VR with Oculus Rift and Touch. |
johnshaughnessy
suggested changes
Jun 8, 2018
There was a problem hiding this comment.
I'd also like the fix to the gyro that came just after the commit chosen for this PR, so if we can bump it all the way to most recent master (or at least to include aframevr/aframe@aaa3bf0), that would be good.
Happy to help bump and test it out.
This was renamed in three.js r93.
|
@johnshaughnessy Updated to latest A-Frame as of today, you should check that your fix is in there if you like. |
This was referenced Aug 19, 2022
This was referenced Aug 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps A-Frame from start-of-May 0.8.2 to start-of-June 0.8.2. Motivation is to get the three.js r92 -> r93 upgrade, which comes with a relevant performance fix.
I tested simple operation in Ubuntu Firefox and Chrome with voice, movement, and duck in 2D. It would be great if anyone wanted to test in VR and with other controller hardware.