Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In World Microphone and Speakers #4237

Merged
merged 2 commits into from
May 7, 2021
Merged

In World Microphone and Speakers #4237

merged 2 commits into from
May 7, 2021

Conversation

netpro2k
Copy link
Contributor

@netpro2k netpro2k commented May 6, 2021

Preliminary support for simulating a PA setup with in world "microphone" and "speakers". By default he "mic" is only available to be used by moderators. Speakers have a configurable audio delay to emphasize or de-emphasize this effect.

image

This PR adds two new components:

  • audio-target: An in world "speaker" that can emit audio from an audio source. Currently the only supported source is an zone-audio-source but this can be expanded to support other sources such as media frames and even mixers to mix multiple sources.

  • zone-audio-soruce: An audio source that will capture and make available the audio source for an object (currently only avatars) that comes near it. Currently it just captures a single source and prevents others from taking control until that source exits (computed locally). This can be expanded a bunch of different ways.

These components should not be considered stable yet as they will likely undergo some changes with the audio refactoring work going on, but they should be useful to start testing with.

They are available in the blender exporter via this PR Hubs-Foundation/hubs-blender-exporter#29

@netpro2k netpro2k requested a review from keianhzo May 6, 2021 19:49
@netpro2k netpro2k added the whats new Include this PR on the "What's New" page label May 6, 2021
@netpro2k netpro2k changed the title Add audio-target and zone-audio-source components In world Microphone and Speakers May 6, 2021
@netpro2k netpro2k changed the title In world Microphone and Speakers In World Microphone and Speakers May 6, 2021
@netpro2k netpro2k merged commit 67fb6d7 into master May 7, 2021
@netpro2k netpro2k deleted the audio-targets branch May 7, 2021 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
whats new Include this PR on the "What's New" page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants