#3149 fix waypoint link reloads room #4272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't love that |
True, the rest of the code relies on it being truthy/falsy, so to prevent things from breaking if return value changes in the future, it would be cleaner to use a new function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes links pointing to waypoint hashes reloading the room.
Clicking on a link with a hash does not compare full urls anymore, instead it checks if the link's domain and room ID match those of the current room. As a side effect, waypoint links now also work on a local client.
Fixes back button sending to last waypoint: when using a waypoint link, the url with hash and the url with cleared hash was added to history. Now uses replaceState() instead.
Fixes RegEx for room/avatar/scene links to NOT match when IDs have more than 7 letters/numbers.