-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NAF Phoenix Adapter #4374
Merged
Merged
Add NAF Phoenix Adapter #4374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netpro2k
reviewed
Jun 25, 2021
…/phoenix-adapter
Also move function bodies to hub-utils
johnshaughnessy
force-pushed
the
feature/refactor-hub-js
branch
from
July 22, 2021 00:32
48152a1
to
e2b2b23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes a few things.
NAF
adapter calledPhoenixAdapter
. ThePhoenixAdapter
handlesnaf
andnafr
events on thehub:${hubId}
phoenix channel, and tellsNAF
when participants join and leave the hub room. (It usesPresence
to know about the other participants.)DialogAdapter
does not have to care aboutNAF
anymore, so it doesn't. We give dialog only the information it needs (serverParams
,hubId
,turn
info etc) to join theprotoo
room and establishWebRTC
connections with the help ofmediasoup
.APP.dialog.isMicEnabled
.localStorage
or in amuted
css class on thescene
.Built on top of #4364