Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NAF Phoenix Adapter #4374

Merged
merged 39 commits into from
Jul 29, 2021
Merged

Add NAF Phoenix Adapter #4374

merged 39 commits into from
Jul 29, 2021

Conversation

johnshaughnessy
Copy link
Contributor

@johnshaughnessy johnshaughnessy commented Jun 25, 2021

This PR changes a few things.

  • There is a new NAF adapter called PhoenixAdapter. The PhoenixAdapter handles naf and nafr events on the hub:${hubId} phoenix channel, and tells NAF when participants join and leave the hub room. (It uses Presence to know about the other participants.)
  • The DialogAdapter does not have to care about NAF anymore, so it doesn't. We give dialog only the information it needs (serverParams, hubId, turn info etc) to join the protoo room and establish WebRTC connections with the help of mediasoup.
  • Mic state is simpler:
    • The source of truth is APP.dialog.isMicEnabled.
    • The mic state is not stored in localStorage or in a muted css class on the scene.
    • We do not toggle the microphone when selecting a new input device from the preference menu.
  • Hub channel presence events are handled by various event handlers, rather than having a small number of event handlers do a bunch of work.

Built on top of #4364

src/hub.js Outdated Show resolved Hide resolved
@johnshaughnessy johnshaughnessy force-pushed the feature/refactor-hub-js branch from 48152a1 to e2b2b23 Compare July 22, 2021 00:32
@johnshaughnessy johnshaughnessy changed the title Refactor hub.js Add NAF Phoenix Adapter Jul 22, 2021
@johnshaughnessy johnshaughnessy changed the base branch from feature/phoenix-adapter to master July 22, 2021 00:33
@johnshaughnessy johnshaughnessy merged commit 9ffd887 into master Jul 29, 2021
@johnshaughnessy johnshaughnessy deleted the feature/refactor-hub-js branch July 29, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants