fix permission token update, use dialog adapter token for kick #4418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yakyouk
changed the title
yakyouk
commented
Jul 16, 2021
| const nextRefresh = new Date(this._permissions.exp * 1000 - 60 * 1000) - new Date(); | ||
| setTimeout(async () => { | ||
| const result = await this.fetchPermissions(); | ||
| this.dispatchEvent(new CustomEvent("permissions-refreshed", { detail: result })); |
There was a problem hiding this comment.
fetchPermissions calls setPermissionsFromToken which dispatches permissions_updated so we don't need to dispatch here.
yakyouk
force-pushed
the
f/dialog-token-update
branch
from
66d97c5 to
16e67dd
Compare
|
The adapter code has changed a bit since you submitted this. This change definitely makes sense though. If you are up for updating it that would be great, otherwise just noting here for whichever one of us on the tip picks up this PR |
yakyouk
force-pushed
the
f/dialog-token-update
branch
3 times, most recently
from
40392e2 to
68a1c24
Compare
bugfix Delete naf-dialog-adapter-copy.js Update hub-channel.js
yakyouk
force-pushed
the
f/dialog-token-update
branch
from
68a1c24 to
db11e3a
Compare
|
I updated the change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove event
permissions-refreshedthat was redundant withpermissions_updated.Simplify permission refresh timer, clear existing timer if permissions are refreshed early.
In
hubChannel.kick, do not refetch permissions so as to pass perms token to NAF dialog adapter'skick; instead, use NAF dialog adapter's_joinTokeninternally.┆Issue is synchronized with this Jira Task