Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix admin 403 images #4565

Merged
merged 13 commits into from
Aug 23, 2021
Merged

Fix admin 403 images #4565

merged 13 commits into from
Aug 23, 2021

Conversation

robinkwilson
Copy link
Contributor

HMC admin panel images were showing a 403 because the root url was hosting the images. This PR changes it so the admin panel images are being requested from the UPLOADS_HOST url.

Adds UPLOADS_HOST defined in Jenkins for HMC.
Will need to define UPLOADS_HOST in HC template for HC before sending deploying it to HC.

Copy link
Contributor

@brianpeiris brianpeiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, LGTM otherwise.

admin/src/react-components/fields.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants