Fixes broken admin scene/avatar listings #5125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, Thank you for the correction ! It would be necessary to put the modified file in the main branch because the current client is unusable with this bug. |
|
@wmurphyrd can you merge this PR into qa-stage branch? |
wmurphyrd
force-pushed
the
admin-assets-fix
branch
from
97bf411 to
b7ee3d5
Compare
|
@robinkwilson updated target & rebased 👍 |
|
Thank you! I'll take care of all the merges. It will make it's way into all of the branches we use for hubs-cloud. Thanks for the help with this!! |
This was referenced Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BASE_ASSETS_PATH was not available in the
process.envgenerated by webpack, so it was undefined when read byconfig.jsGot this after meting in latest hubs-cloud:
After this fix:
Others reporting this issue on Discord:
https://discord.com/channels/498741086295031808/819203046931693589/941487090942742548
This fix doesn't really explain what went wrong - as this isn't a new env var and wasn't in the webpack defines before, but it works 🙃