Update node.js to v16. Minor and patch updates to dependencies #5485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netpro2k
reviewed
Jun 6, 2022
| @@ -70,5 +70,8 @@ | |||
| "webpack-cli": "^3.2.3", | |||
| "webpack-dev-server": "^3.1.14", | |||
| "worker-loader": "^2.0.0" | |||
| }, | |||
| "overrides": { | |||
| "three": "github:mozillareality/three.js#hubs/master" | |||
There was a problem hiding this comment.
I think this should match what is in the main hubs package.json
There was a problem hiding this comment.
Makes sense. I think I just happen to open this PR when we were in the middle of a three.js update.
|
Closed in favor of #5619 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our package-lock versions so that we can update to node.js v16. It updates the node.js version we use in our habitat build plan. It also updates several dependencies to newer patch and minor versions. Finally, it resolves some warnings from babel and SASS that resulted from newer versions of those libraries.
I've done some initial testing locally, and haven't spotted any regressions yet, but we might only be able to find some issues in a staging environment.
TODO: