Fix spawner issues #6158
Fix spawner issues #6158
Conversation
|
Thanks for working on it. Would you mind if writing the details in the PR comment for reviewers and future readers to follow the change and background? |
|
I confirmed that this change resolves the spanwer object problem that spawner object isn't renderred (at the correct position) for now.
Sounds like it's a good fix. I add some comments as just question for my study. You can ignore them if you are busy. Honestly I'm not familiar with physics and spawners so can't review in details. But spawner objects will be rendered correctly with this change so I think good to go with the change. If more detailed review is needed, please ask other devs (maybe @johnshaughnessy). |
| spawnerObj.visible = true; | ||
|
|
||
| // TODO we should come up with a nicer way to get at the media that was loaded by a MediaLoader | ||
| yield* animateScale(world, spawnerObj.children[0]!.eid!); |
There was a problem hiding this comment.
Question for my study: Here can be removed because of animateLoad: true?
There was a problem hiding this comment.
Yes, as we are already animating the spawned object I don't see the point on animating explicitly.
|
|
||
| addComponent(world, ObjectSpawner, eid); | ||
| ObjectSpawner.src[eid] = APP.getSid(props.src); | ||
| ObjectSpawner.flags[eid] = props.mediaOptions?.applyGravity ? OBJECT_SPAWNER_FLAGS.APPLY_GRAVITY : 0; | ||
|
|
||
| inflateRigidBody(world, eid, { | ||
| mass: 0, | ||
| type: Type.STATIC, |
There was a problem hiding this comment.
Question for my study: Spawner object should be static (no local matrix update except for initialization) so rigid body type should be static. Is my understanding correct?
There was a problem hiding this comment.
That's my understanding. Spawners are static as their main action is to spawn an object and are not draggable. Also that's how we were setting them up in AFrame:
https://github.com/mozilla/hubs/blob/5f6e7a62ab998a60895a30dc686ae6db94fe9c5b/src/gltf-component-mappings.js#L323
keianhzo
force-pushed
the
bitecs-spawner-fix
branch
from
1e32805 to
5f6e7a6
Compare
This PR addresses some issues with the spawner and how the spawner component and the spawned objects are created (static, recentered, resized) and reorders the physics related systems so that we give a chance to the physics system to create bodies and shapes before they are processed by other systems.