Add a bunch of killer animations #696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged
brianpeiris
reviewed
Nov 12, 2018
| from: { x: currentScale.x * 1.1, y: currentScale.y * 1.1, z: currentScale.z * 1.1 }, | ||
| to: { x: currentScale.x, y: currentScale.y, z: currentScale.z }, | ||
| easing: "easeOutElastic" | ||
| }); |
There was a problem hiding this comment.
Not sure what you were going for with this animation, but it's so fast that it just looks like a glitch, almost like it's broken -- the elastic easing is barely noticeable since it has a relatively long ramp up. I would suggest easeInQuad for 80ms, delay for 90ms and then easeOutQuad for 80ms.
There was a problem hiding this comment.
Also, not sure if this is intentional, but the animation also happens when you move a pinned object.
There was a problem hiding this comment.
It's meant to make the object feel "stiffened in place", so the vibrations were intention but I agree it's pretty subtle. I'll see if I can make it more clear
| easing: "easeInQuad" | ||
| }); | ||
|
|
||
| this.el.parentNode.setAttribute("visible", false); |
There was a problem hiding this comment.
If this was supposed to hide the menu, it doesn't since visible-while-frozen resets the visibility on tick.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this app is starting to feel pretty legit :)