Rotate and align objects easily #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
johnshaughnessy
commented
Jan 17, 2019
johnshaughnessy
commented
Jan 17, 2019
johnshaughnessy
commented
Jan 17, 2019
johnshaughnessy
force-pushed
the
feature/rotation-buttons
branch
from
2117576 to
c2d2adc
Compare
netpro2k
suggested changes
Jan 18, 2019
| const shouldBeVisible = | ||
| ((isFrozen && this.data.visible) || (!isFrozen && !this.data.visible)) && | ||
| isWithinDistance && | ||
| !AFRAME.scenes[0].systems["rotate-selected-object"].active; |
There was a problem hiding this comment.
Hmm, this seems odd. I assume the primary intent is to hide the freeze menu on the object you are rotating? I feel like the rotate-button component should just set a flag (enabled ?) on this component instead.
There was a problem hiding this comment.
Is it actually less odd for the rotate button to be setting the visibility of the freeze menu? I thought the ideal situation be that the rotate button wouldn't know about the freeze menu and vice versa (e.g. visibility arbiter). Not sure if it's worth the effort to decomplect them like that, but seems like it's arbitrary whether visibility-while-frozen depends on rotate-button or vice versa.
brianpeiris
added
whats new
This was referenced Aug 19, 2022
This was referenced Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now use the "rotate" and "align" buttons to reorient objects in the scene.