Fix LanesView not hidden when it should be hidden #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NaifAlrashed
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hide LaneView when Navigation is starting but make sure it shows up if the route contains lane information
Tasks
update(for visualInstruction: VisualInstructionBanner?)handle show & hideInfos for Reviewer
The underlying issue was that we animated the alpha value of the LanesView and therefore didn't show up if there was a lane instruction.
I've used a route in Berlin using Mapbox API to obtain a route which I know contains lane information. Please note that our map style doesn't contain map data in this region, thats why it's empty. The route works regardless.