Refactor welcome email trigger location

Moved the triggering of the welcome email from GitHub OAuth event handler to UserService. Now, the welcome email is sent when a new user is created in UserService instead of after successful GitHub authentication. This change ensures that all new users, regardless of their method of registration, receive a welcome email.

apps/shelve/server/routes/auth/github.ts

@@ -28,7 +28,6 @@ export default defineOAuthGitHubEventHandler({
         },
         loggedInAt: new Date().toISOString(),
       })
-      await emailService.sendWelcomeEmail(user.email, user.login)
       return sendRedirect(event, '/app/projects')
     } catch (error) {
       console.error('GitHub OAuth error:', error)

apps/shelve/server/services/user.service.ts

@@ -1,4 +1,5 @@
 import type { publicUser, User, CreateUserInput, UpdateUserInput } from '@shelve/types'
+import { EmailService } from '~~/server/services/resend.service'
 
 export class UserService {
 
@@ -30,8 +31,12 @@ export class UserService {
       create: {
         ...createUserInput,
         username: newUsername,
-      },
-    })
+      }
+    }) as User
+    if (user.createdAt === user.updatedAt) {
+      const emailService = new EmailService()
+      await emailService.sendWelcomeEmail(user.email, user.username)
+    }
 
     return this.formatUser(user)
   }