feat: Send welcome email for new user #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #267 Add functionality to send a welcome email upon the creation of a new user's first OAuth account. * **New Welcome Email Template**: Create a new Vue email template in `apps/shelve/server/emails/welcomeEmail.vue` that includes a comprehensive guide with next steps, helpful resources, tips, and an overview of the platform's features. * **Email Service Updates**: Modify `apps/shelve/server/services/resend.service.ts` to include a method for sending the welcome email using the new template. Update the `sendOtp` method to use the new `generateOtpTemplate` method. * **GitHub OAuth Route Updates**: Modify `apps/shelve/server/routes/auth/github.ts` to import the `EmailService` and call the `sendWelcomeEmail` method after successfully creating a new user. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/HugoRCD/shelve/issues/267?shareId=XXXX-XXXX-XXXX-XXXX).
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you for following the naming conventions! 🙏 |
1 similar comment
|
Thank you for following the naming conventions! 🙏 |
This commit introduces a new feature that allows admins to test the sending of welcome emails to new users. A new 'Tests' section has been added in the admin navigation for this purpose. The code also includes error handling for failed email sends. In addition, changes have been made to the content of the welcome email sent to new users. The invitation to join our community has been removed from the message. Also, if a username is not available, the user's email will be used in the greeting instead.
Moved the triggering of the welcome email from GitHub OAuth event handler to UserService. Now, the welcome email is sent when a new user is created in UserService instead of after successful GitHub authentication. This change ensures that all new users, regardless of their method of registration, receive a welcome email.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267
Add functionality to send a welcome email upon the creation of a new user's first OAuth account.
apps/shelve/server/emails/welcomeEmail.vuethat includes a comprehensive guide with next steps, helpful resources, tips, and an overview of the platform's features.apps/shelve/server/services/resend.service.tsto include a method for sending the welcome email using the new template. Update thesendOtpmethod to use the newgenerateOtpTemplatemethod.apps/shelve/server/routes/auth/github.tsto import theEmailServiceand call thesendWelcomeEmailmethod after successfully creating a new user.For more details, open the Copilot Workspace session.