enhancement: Add migration system from Prisma and improve overall types and DTO #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
Thank you for following the naming conventions! 🙏 |
- Enhanced type safety in various services by specifying types explicitly. - Optimized several service methods for better performance and readability. - Refactored user role checking logic in middleware for clarity. - Updated Prisma schema to use enums for roles, improving data integrity. - Created new SQL migration file to reflect changes in the database schema. - Simplified some API handlers by removing unnecessary lines of code.
HugoRCD
changed the title
HugoRCD
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes multiple changes across various files to improve code quality, add new features, and fix bugs. The most important changes include updates to the Prisma schema and migrations, enhancements to the
useTeamscomposable, and various code simplifications.Database Schema and Migrations:
TeamRoleandRoleand updated theUser,Member, andTeammatemodels to use these enums in the Prisma schema (apps/shelve/prisma/schema.prisma). [1] [2] [3]apps/shelve/prisma/migrations/20241106215403_init/migration.sql).apps/shelve/prisma/migrations/migration_lock.toml).useTeamsComposable Enhancements:responseto_memberand updated logic for handling member addition and updates (apps/shelve/app/composables/useTeams.ts). [1] [2]apps/shelve/app/composables/useTeams.ts). [1] [2]Code Simplifications:
apps/shelve/app/middleware/admin.ts).apps/shelve/server/api/admin/users/index.get.ts,apps/shelve/server/api/teams/[teamId]/index.delete.ts,apps/shelve/server/api/teams/[teamId]/members/index.post.ts,apps/shelve/server/api/teams/index.get.ts). [1] apps/shelve/server/api/teams/[teamId]/index.delete.tsL10-R10, apps/shelve/server/api/teams/[teamId]/members/index.post.tsL8-R9, [2]Configuration Updates:
siteUrlandappUrlin the Nuxt configuration files (apps/lp/nuxt.config.ts,apps/shelve/nuxt.config.ts). [1] [2]Type Improvements:
selectedEnvironmentinuseVariablescomposable (apps/shelve/app/composables/useVariables.ts).users.vueto useUserinstead ofpublicUser(apps/shelve/app/pages/admin/users.vue). [1] [2] [3] [4] [5]These changes collectively improve the maintainability, functionality, and performance of the codebase.
resolve #286