Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error on copy paste if key value has '=' #311

Merged
merged 4 commits into from
Nov 14, 2024
Merged

fix: error on copy paste if key value has '=' #311

merged 4 commits into from
Nov 14, 2024

Conversation

HugoRCD
Copy link
Owner

@HugoRCD HugoRCD commented Nov 14, 2024

Fixes #308

Fix error on copy-paste if key value has '='.

  • apps/shelve/app/components/project/CreateVariables.vue
    • Update parseEnvFile function to split only on the first '='.
    • Update paste event handler to split only on the first '='.
  • apps/lp/app/components/vault/Encrypt.vue
    • Update saveEnvFile function to split only on the first '='.
  • apps/lp/app/components/vault/Decrypt.vue
    • Update decryptEnvFile function to split only on the first '='.
  • packages/cli/src/utils/env.ts
    • Update copyEnv function to split only on the first '='.
    • Update downloadEnv function to split only on the first '='.
  • apps/shelve/app/utils/clipboard.ts
    • Update copyToClipboard function to split only on the first '='.

For more details, open the Copilot Workspace session.

Fixes #308

Fix error on copy-paste if key value has '='.

* **apps/shelve/app/components/project/CreateVariables.vue**
  - Update `parseEnvFile` function to split only on the first '='.
  - Update `paste` event handler to split only on the first '='.
* **apps/lp/app/components/vault/Encrypt.vue**
  - Update `saveEnvFile` function to split only on the first '='.
* **apps/lp/app/components/vault/Decrypt.vue**
  - Update `decryptEnvFile` function to split only on the first '='.
* **packages/cli/src/utils/env.ts**
  - Update `copyEnv` function to split only on the first '='.
  - Update `downloadEnv` function to split only on the first '='.
* **apps/shelve/app/utils/clipboard.ts**
  - Update `copyToClipboard` function to split only on the first '='.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/HugoRCD/shelve/issues/308?shareId=XXXX-XXXX-XXXX-XXXX).
Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
shelve-app ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 8:33pm
shelve-lp ⬜️ Skipped (Inspect) Nov 14, 2024 8:33pm

Copy link

github-actions bot commented Nov 14, 2024

Thank you for following the naming conventions! 🙏

@github-actions github-actions bot added the bug Something isn't working label Nov 14, 2024
Copy link

pkg-pr-new bot commented Nov 14, 2024

Open in Stackblitz

bun add https://pkg.pr.new/HugoRCD/shelve/@shelve/cli@311

commit: 4a89d36

@vercel vercel bot temporarily deployed to Preview – shelve-lp November 14, 2024 20:33 Inactive
@HugoRCD HugoRCD merged commit b827672 into main Nov 14, 2024
12 checks passed
@HugoRCD HugoRCD deleted the fix/308 branch November 14, 2024 20:36
@HugoRCD HugoRCD self-assigned this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: error on copy paste if key value has '='
1 participant