fix: Error on project delete #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
Thank you for following the naming conventions! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
apps/shelveapplication, focusing on enhancing user experience and improving code quality. The most important changes include adding autofocus to a form input, ensuring type safety in a composable function, and updating variable names for clarity.User experience improvements:
apps/shelve/app/components/project/MainSection.vue: Addedautofocusto theFormGroupinput field to enhance user experience when confirming project deletion.Code quality improvements:
apps/shelve/app/composables/useVariables.ts: Added non-null assertion operator to ensure type safety when accessingvariablesInput.value.variables[index].apps/shelve/app/pages/project/[projectId]/index.vue: Renamedlinkstoitemsfor better clarity and consistency in the navigation menu. (apps/shelve/app/pages/project/[projectId]/index.vueL26-R26, apps/shelve/app/pages/project/[projectId]/index.vueL57-R65)Bug fixes:
apps/shelve/app/pages/projects.vue: ChangedfetchProjects()toawait fetchProjects()to ensure projects are fetched before continuing.resolve #314