Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NoisyObs. #23

Merged
merged 9 commits into from
Jun 30, 2020
Merged

Add NoisyObs. #23

merged 9 commits into from
Jun 30, 2020

Conversation

pedrofreire
Copy link
Contributor

No description provided.

@pedrofreire pedrofreire requested review from AdamGleave and qxcv June 27, 2020 18:59
Copy link
Member

@AdamGleave AdamGleave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- some minor changes requested but don't think I need to review again

src/seals/diagnostics/noisy_obs.py Outdated Show resolved Hide resolved
src/seals/diagnostics/noisy_obs.py Outdated Show resolved Hide resolved
src/seals/diagnostics/noisy_obs.py Outdated Show resolved Hide resolved
src/seals/util.py Show resolved Hide resolved
@AdamGleave AdamGleave mentioned this pull request Jun 30, 2020
Co-authored-by: Adam Gleave <adam@gleave.me>
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #23   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        15    +1     
  Lines          447       478   +31     
=========================================
+ Hits           447       478   +31     
Impacted Files Coverage Δ
src/seals/diagnostics/__init__.py 100.00% <100.00%> (ø)
src/seals/diagnostics/noisy_obs.py 100.00% <100.00%> (ø)
src/seals/util.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06b0b79...6b3230f. Read the comment docs.

Copy link
Member

@AdamGleave AdamGleave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrofreire pedrofreire merged commit edad224 into master Jun 30, 2020
@pedrofreire pedrofreire deleted the noisy-1 branch June 30, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants