Test rendering of environments #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…move sharding which is not really justified given small test suite
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 683 700 +17
=========================================
+ Hits 683 700 +17
Continue to review full report at Codecov.
|
shwang
approved these changes
Nov 10, 2020
| auth: | ||
| username: $DOCKERHUB_USERNAME | ||
| password: $DOCKERHUB_PASSWORD | ||
| working_directory: /seals |
There was a problem hiding this comment.
I'm okay with this, but curious why you introduced a default dict given that it's only used once in this config. Maybe for reduced nesting or standardized config.yml form?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test case to verify that
render()in environments is implemented correctly. Also add a mock X server to the Docker image to enable these tests to run on CI.